Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integration mito2 with inverted index #3029

Closed
wants to merge 37 commits into from
Closed

feat: integration mito2 with inverted index #3029

wants to merge 37 commits into from

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Dec 28, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added Invalid PR Title docs-required This change requires docs update. labels Dec 28, 2023
zhongzc and others added 11 commits December 28, 2023 10:11
@zhongzc
feat(inverted_index.integration): Add applier builder to convert Expr…
ff2de5b 
… to Predicates (Part 1)

Signed-off-by: Zhenchi <[email protected]>
@zhongzc
chore: add docs
55fc1f9 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
fix: typos
09639a7 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
fix: address comments
19c5f38 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc @evenyag
Update src/mito2/src/sst/index/applier/builder.rs
a1792d1 
Co-authored-by: Yingwen <[email protected]>
@zhongzc
add some metrics
315c77b 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
track io bytes
6f181c4 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
add comments
c5b3d69 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
instrument object store to track its usage
56d1621 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
store is nice
2f9319a 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
remove some unwraps
50d8a1b 
Signed-off-by: Zhenchi <[email protected]>
@sunng87 sunng87 mentioned this pull request Dec 29, 2023
Closed
@zhongzc
typos
dc2b433 
Signed-off-by: Zhenchi <[email protected]>
@sunng87 sunng87 mentioned this pull request Dec 29, 2023
Closed
@zhongzc
fix: remove unwrap
9c98034 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
Merge remote-tracking branch 'zhongzc/zhongzc/inverted-index-integrat…
25bb4cc 
…ion-applier-builder-part-1' into zhongzc/index-integration
@sunng87 sunng87 mentioned this pull request Dec 30, 2023
Closed
@github-actions github-actions bot added docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Dec 30, 2023
@zhongzc zhongzc changed the title [draft] integration mito2 with inverted index feat: integration mito2 with inverted index Dec 30, 2023
@zhongzc zhongzc marked this pull request as ready for review December 30, 2023 04:10
@zhongzc
fix: toml format
d5c38b3 
Signed-off-by: Zhenchi <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2023 •
edited
Loading

Codecov Report

Attention: 193 lines in your changes are missing coverage. Please review.

Comparison is base (1fc168b) 85.52% compared to head (d5c38b3) 84.96%.

❗ Current head d5c38b3 differs from pull request most recent head 384632f. Consider uploading reports for the commit 384632f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3029      +/-   ##
==========================================
- Coverage   85.52%   84.96%   -0.56%     
==========================================
  Files         818      808      -10     
  Lines      133850   129805    -4045     
==========================================
- Hits       114474   110294    -4180     
- Misses      19376    19511     +135

@zhongzc zhongzc marked this pull request as draft December 30, 2023 04:32
zhongzc added 10 commits December 30, 2023 06:35
@zhongzc
feat: add filter metrics
983c09c 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
add abort
3ed9b30 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
Merge remote-tracking branch 'origin/main' into zhongzc/index-integra…
1a963a4 
…tion
@zhongzc
chore: polish
6115d8f 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
feat: add seek count
915f222 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
Merge remote-tracking branch 'origin/main' into zhongzc/index-integra…
f049ace 
…tion
@zhongzc
remove reduntant code
73eaaca 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
feat: add inverted_index_available to file meta
ac2367c 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc
Merge remote-tracking branch 'origin/main' into zhongzc/index-integra…
9cda68a 
…tion
@zhongzc
fix test
e38d6cc 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc zhongzc force-pushed the zhongzc/index-integration branch from 071715d to e38d6cc Compare January 5, 2024 06:15
@zhongzc zhongzc force-pushed the zhongzc/index-integration branch from ecb30dd to 8e01dfd Compare January 5, 2024 06:40
@github-actions github-actions bot added Size: L and removed Size: XL labels Jan 10, 2024
@zhongzc
tiny refine
384632f 
Signed-off-by: Zhenchi <[email protected]>
@zhongzc zhongzc closed this Jan 12, 2024
@zhongzc zhongzc deleted the zhongzc/index-integration branch January 12, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag Awaiting requested review from evenyag evenyag will be requested when the pull request is marked ready for review evenyag is a code owner

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r v0y4g3r will be requested when the pull request is marked ready for review v0y4g3r is a code owner

@waynexia waynexia Awaiting requested review from waynexia waynexia will be requested when the pull request is marked ready for review waynexia is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zhongzc